Link directly to cargo install page #1994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
jtgeibel
force-pushed
the
papercut/frontpage-install-button
branch
from
9bf676c to
58c39c3
Compare
Turbo87
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
seems totally reasonable to me!
do we still use the install route afterwards? was it done that way to not break existing links to https://crates.io/install?
This fixes a papercut where after clicking on the button, clicking the back button causes the user to immediately redirect again. Additionally, on Firefox 71, it was not possible to long-click on the back button to return to crates.io (as the only entry in the list was the redirect. On Chromium 79 I had no such issue.
jtgeibel
force-pushed
the
papercut/frontpage-install-button
branch
from
58c39c3 to
2eebe8b
Compare
|
I've amended the commit to drop the
Yes, I left it in case there are external pages linking to that URL. I don't think there are any remaining internal uses of it. @bors r=Turbo87 |
|
📌 Commit 2eebe8b has been approved by |
bors
added a commit
that referenced
this pull request
Dec 21, 2019
…urbo87 Link directly to cargo install page This fixes a paper-cut where after clicking on the button, clicking the back button causes the user to immediately redirect again. Additionally, on Firefox 71, it was not possible to long-click on the back button to return to crates.io (as the only entry in the list was the redirect. On Chromium 79 I had no such issue.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a paper-cut where after clicking on the button, clicking the
back button causes the user to immediately redirect again.
Additionally, on Firefox 71, it was not possible to long-click on the
back button to return to crates.io (as the only entry in the list was
the redirect. On Chromium 79 I had no such issue.