Use the percy media query method to hide the downloads graph from percy #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
|
WOO ok this works at least, hides the download graph in both cases!! It's not super great that this CSS would be in prod, but it's only a tiny bit sooo 🤷♀ r? @jtgeibel wdyt? |
|
There probably is a way to only include the CSS snippet on Travis, but even if we spend the time to figure it out it doesn't buy us much, while at the same time increasing the risk of bugs that only happen in production, so I wouldn't bother. |
|
LGTM! @bors: r+ |
|
📌 Commit d031ca0 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 21, 2019
Use the percy media query method to hide the downloads graph from percy This is a different attempt to fix the percy problems; the percy yaml config doesn't work with the ember-percy version we're currently on.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different attempt to fix the percy problems; the percy yaml config doesn't work with the ember-percy version we're currently on.