Skip to content

Configure percy to hide the downloads graph (upgrade to percy 2.0.0 beta) #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

carols10cents
Copy link
Member

Trying just this change by itself

@rust-highfive
Copy link

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents
Copy link
Member Author

Don't merge this yet-- I expected this to have 2 differences in the snapshots, but there aren't any. I'm trying to get in touch with Percy support to see if I messed something up or if my expectations are incorrect.

@carols10cents carols10cents changed the title Configure percy to hide the downloads graph Configure percy to hide the downloads graph (upgrade to percy 2.0.0 beta) Dec 20, 2019
@carols10cents
Copy link
Member Author

The percy team mentioned they just released a beta that might fix the problems and that would support the percy yaml config. The travis logs contain lines that say percy finished the build, but the percy page still says it's waiting.... so I've contacted support again with this info. I think we'll probably be better off with #2016 for now.

@bors
Copy link
Contributor

bors commented Dec 20, 2019

☔ The latest upstream changes (presumably #2024) made this pull request unmergeable. Please resolve the merge conflicts.

@carols10cents
Copy link
Member Author

Ok, so this seems to work too! I think I still slightly prefer #2016 until @percy/ember is out of beta, interested to see what @jtgeibel or anyone else thinks.

I still have to re-submit the changes that remove the duplicate tests and fix the search tests....

@bors
Copy link
Contributor

bors commented Dec 20, 2019

☔ The latest upstream changes (presumably #2023) made this pull request unmergeable. Please resolve the merge conflicts.

@jtgeibel
Copy link
Member

I've merged #2016. I also think it makes sense to pursue this further once it is out of beta.

@carols10cents carols10cents deleted the hide-graph-from-percy branch December 23, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants