Converting more tests #1563
Merged
Converting more tests #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what version generated the old lockfile, but this is with a clean checkout of crates.io, installing node 10.13.0 and npm 6.4.1 and doing `npm install`
Ran into some of these myself while setting up a fresh dev env.
I changed the test to work in a slightly different, yet still valid IMO, way and wanted to call this out.
These method work for either team or user owners, but wasn't really clear about that.
jtgeibel
approved these changes
Nov 29, 2018
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the commits in #1556
omg i got to delete a whole bunch of stufffff!!!
Still not everything converted, but we're getting close!!