Skip to content

Fix typo #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix typo #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blog/_posts/2019-11-13-find-usages.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ These restrictions can originate from the language semantics: it doesn't make se
They also can originate from the user: it's often convenient to exclude tests from search results, for example.

The second trick is about implementing warnings for unused declarations effectively.
This is a case where a top-down approach is generally better, as an IDE needs to process every declaration, and that would be slow with top-down approach.
This is a case where a top-down approach is generally better, as an IDE needs to process every declaration, and that would be slow with bottom-up approach.
Copy link
Member

@lnicola lnicola Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have said "a bottom-up approach", but I fixed it manually after merging 😄.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this one. Thanks!

However, with a trigram index the IDE can apply an interesting optimization: only check those declarations which have few textual matches.
This will miss an used declaration with a popular name, like `new`, but will work ok for less-popular names, with a relatively good performance.

Expand Down