Skip to content

Fix typo #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix typo #194

merged 1 commit into from
Jan 12, 2023

Conversation

garandria
Copy link
Contributor

No description provided.

@lnicola
Copy link
Member

lnicola commented Jan 12, 2023

Thanks!

@lnicola lnicola merged commit 789361c into rust-analyzer:src Jan 12, 2023
@@ -157,7 +157,7 @@ These restrictions can originate from the language semantics: it doesn't make se
They also can originate from the user: it's often convenient to exclude tests from search results, for example.

The second trick is about implementing warnings for unused declarations effectively.
This is a case where a top-down approach is generally better, as an IDE needs to process every declaration, and that would be slow with top-down approach.
This is a case where a top-down approach is generally better, as an IDE needs to process every declaration, and that would be slow with bottom-up approach.
Copy link
Member

@lnicola lnicola Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have said "a bottom-up approach", but I fixed it manually after merging 😄.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this one. Thanks!

lnicola added a commit that referenced this pull request Aug 14, 2023
lnicola added a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants