Skip to content

Upgrade @asyncio.coroutine to async #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Upgrade @asyncio.coroutine to async #181

merged 5 commits into from
Apr 16, 2020

Conversation

lsabi
Copy link
Contributor

@lsabi lsabi commented Mar 27, 2020

Reason for the change
Solved issue #180

Description
Simply upgraded functions to
async def function():

For now I only changed the functions in the asyncio_net folder.

Code examples
See above

Checklist

  • Unit tests created/modified
  • Integration tests created/modified

@lsabi
Copy link
Contributor Author

lsabi commented Apr 16, 2020

Do you get any errors with the integration tests?

@gabor-boros
Copy link
Member

@lsabi I checked it on travis, and I can see no integration test errors there

@lsabi
Copy link
Contributor Author

lsabi commented Apr 16, 2020

Then the PR can be merged, unless someone has something to say.

@gabor-boros gabor-boros merged commit aa5b0d6 into rethinkdb:python-2-to-3 Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants