This repository was archived by the owner on Jun 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Refactor PPX: move across files and clean up exceptions #638
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
(executable | ||
(name res_cli) | ||
(public_name rescript) | ||
(modes byte exe) | ||
(flags | ||
(-open Syntax -open Compilerlibs406) | ||
(:standard -w +a-4-42-40-9-48)) | ||
(:standard -w +a-4-42-40-9-48-70)) | ||
(libraries syntax compilerlibs406)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
open Asttypes | ||
open Parsetree | ||
|
||
type jsxConfig = { | ||
mutable version: int; | ||
mutable module_: string; | ||
mutable mode: string; | ||
mutable nestedModules: string list; | ||
mutable hasReactComponent: bool; | ||
} | ||
|
||
(* Helper method to look up the [@react.component] attribute *) | ||
let hasAttr (loc, _) = loc.txt = "react.component" | ||
|
||
(* Iterate over the attributes and try to find the [@react.component] attribute *) | ||
let hasAttrOnBinding {pvb_attributes} = | ||
List.find_opt hasAttr pvb_attributes <> None | ||
|
||
let raiseError ~loc msg = Location.raise_errorf ~loc msg | ||
|
||
let raiseErrorMultipleReactComponent ~loc = | ||
raiseError ~loc | ||
"Only one component definition is allowed for each module. Move to a \ | ||
submodule or other file if necessary." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side comment:
byte
for debugger maybe?Any runtime debugger suggestion? I haven't tried it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because otherwise dune does not generate files required by reanalyze.
But for standalone executable it should be possible.
Notice the debugger is not so user friendly though so one needs to try a bit and asses when it's worth using it.