This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Refactor PPX: move across files and clean up exceptions #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move PPX V3 and V4 back to different files. Clean up treatment of exceptions.
mununki
reviewed
Sep 18, 2022
| @@ -1,7 +1,8 @@ | |||
| (executable | |||
| (name res_cli) | |||
| (public_name rescript) | |||
| (modes byte exe) | |||
There was a problem hiding this comment.
Side comment: byte for debugger maybe?
Any runtime debugger suggestion? I haven't tried it yet.
There was a problem hiding this comment.
This is because otherwise dune does not generate files required by reanalyze.
But for standalone executable it should be possible.
Notice the debugger is not so user friendly though so one needs to try a bit and asses when it's worth using it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PPX V3 and V4 back to different files.
Clean up treatment of exceptions.