Skip to content

Build tests clean up #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions jscomp/build_tests/case/.gitignore

This file was deleted.

16 changes: 0 additions & 16 deletions jscomp/build_tests/case/README.md

This file was deleted.

10 changes: 9 additions & 1 deletion jscomp/build_tests/case/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@ var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var o = p.spawnSync(rescript_exe, { encoding: "utf8", cwd: __dirname });

assert.ok(o.stderr.match(/different cases/).length > 0);
if (
![
`Error: Invalid bsconfig.json implementation and interface have different path names or different cases src/demo vs src/Demo\n`,
// On linux files are parsed in different order
`Error: Invalid bsconfig.json implementation and interface have different path names or different cases src/Demo vs src/demo\n`,
].includes(o.stderr)
) {
assert.fail(o.stderr);
}
16 changes: 0 additions & 16 deletions jscomp/build_tests/case/package.json

This file was deleted.

25 changes: 0 additions & 25 deletions jscomp/build_tests/case2/.gitignore

This file was deleted.

16 changes: 0 additions & 16 deletions jscomp/build_tests/case2/README.md

This file was deleted.

10 changes: 9 additions & 1 deletion jscomp/build_tests/case2/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@ var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
var o = p.spawnSync(rescript_exe, { encoding: "utf8", cwd: __dirname });

assert.ok(o.stderr.match(/different cases/).length > 0);
if (
![
`Error: Invalid bsconfig.json implementation and interface have different path names or different cases src/X vs src/x\n`,
// On linux files are parsed in different order
`Error: Invalid bsconfig.json implementation and interface have different path names or different cases src/x vs src/X\n`,
].includes(o.stderr)
) {
assert.fail(o.stderr);
}
16 changes: 0 additions & 16 deletions jscomp/build_tests/case2/package.json

This file was deleted.

27 changes: 0 additions & 27 deletions jscomp/build_tests/case3/.gitignore

This file was deleted.

16 changes: 0 additions & 16 deletions jscomp/build_tests/case3/README.md

This file was deleted.

4 changes: 2 additions & 2 deletions jscomp/build_tests/case3/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ var fs = require("fs");
var path = require("path");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;
p.spawnSync(rescript_exe, {
p.spawnSync(`${rescript_exe} clean && ${rescript_exe} build`, {
encoding: "utf8",
cwd: __dirname,
});

var o = fs.readFileSync(path.join(__dirname, "src", "hello.bs.js"), "ascii");
assert.ok(/HelloGen.f/.test(o));
assert.ok(/HelloGen\.f/.test(o));
64 changes: 0 additions & 64 deletions jscomp/build_tests/case3/package-lock.json

This file was deleted.

17 changes: 0 additions & 17 deletions jscomp/build_tests/case3/package.json

This file was deleted.

11 changes: 11 additions & 0 deletions jscomp/build_tests/case3/src/hello.bs.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 0 additions & 25 deletions jscomp/build_tests/custom_namespace/.gitignore

This file was deleted.

16 changes: 0 additions & 16 deletions jscomp/build_tests/custom_namespace/README.md

This file was deleted.

2 changes: 0 additions & 2 deletions jscomp/build_tests/custom_namespace/input.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
var child_process = require("child_process");
var fs = require("fs");
var path = require("path");
var assert = require("assert");
var rescript_exe = require("../../../scripts/bin_path").rescript_exe;

Expand Down
16 changes: 0 additions & 16 deletions jscomp/build_tests/custom_namespace/package.json

This file was deleted.

Loading