Skip to content

Build tests clean up #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2023
Merged

Build tests clean up #6365

merged 4 commits into from
Aug 22, 2023

Conversation

DZakh
Copy link
Member

@DZakh DZakh commented Aug 21, 2023

  • Removed files unrelated to tests to make it clear what's actually tested.
  • Removed npm link added in the PR, since we run rescript directly from binary.

@DZakh DZakh changed the title Built tests clean up Build tests clean up Aug 21, 2023
cristianoc
cristianoc approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great cleanup.
In other situations, tests are forced to process files in a deterministic order, but for these tiny tests providing 2 outputs seems like the simplest way.
Is it ready to merge?

@DZakh
Copy link
Member Author

DZakh commented Aug 22, 2023

Yes, it's ready to merge if tests pass.

@cristianoc cristianoc merged commit bc2840e into rescript-lang:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DZakh @cristianoc