Take over changes from 10.1 release into master #5771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `.bs.mjs`, `.bs.cjs` to fill the gap between `.bs.js` and `.mjs` - `.res.js`, `.res.mjs`, `.res.cjs` to assist BS → ReScript rebranding
* Alllow .res files in stdlib Files in stdlib use ocamldep to figure out dependencies. Allow .res files and temporarily convert them to .ml to feed them to ocamldep * The dependencies in others/ were processed twice in parallel... * format * Dedicated bsc option to stop after parsing. So one can convert to .ml without ovewrtiting ".cm*" files. * Use a temporary dir to avoid touching the jscomp/others dir. * Remove the async changes. No need to protect now that a temporary dir is used for temporary .ml files. Of course, it would be nice to clean up the build, separately. * Update scripts/ninja.js more idiomatic path parse Co-authored-by: woonki <woonki.moon@gmail.com> * small clean up refactor * temp dir * Clean up ninja as per the review comments. * Remove example files from stdlib. * deep clean * shell and format Co-authored-by: woonki <woonki.moon@gmail.com>
Introduce safe promises, based on rescript-lang#5707 - Add t-first Js.Promise2 with safe bindings - Remove type check for nested promises - Add example illustrating a typical example of nested promises, and how it goes away with Js.Promise2
…r was no… (rescript-lang#5744)" This reverts commit a8b0cfb.
…char_exhaustiveness_check Revert "Fix issue where exhaustiveness check for pattern matching char was no…"
* Prevent inlining of async functions Fixes rescript-lang#5754 * Update CHANGELOG.md * Refactor logic to disable inlining of async functions. * Prevent all async function beta reductions.
`make test-gentype`
* change Pconst_char payload (WIP) * tweak * tweak * representation of char for lambda * lib * bugfix: replace wrong pp * libs * bugfix: replace wrong print * use unsafe_chr to handle possible overflow char * safe print int as char * reduce duplication * (re)use encodeCodepoint to support string_of_int_as_char * some refactor * libs * changelog
cristianoc
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes over all changes from the
10.1_releasebranch into master.I tested the resulting package against our latest project including JSX 4. Looks good.