Skip to content

JsxDOMStyle.t: add backgroundFilter prop #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

JsxDOMStyle.t: add backgroundFilter prop #5716

merged 1 commit into from
Oct 3, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 2, 2022

@cknitt cknitt requested a review from mununki October 2, 2022 17:20
mununki
mununki approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to add this in ReactDOMStyle.res in rescript-react?

@cknitt
Copy link
Member Author

cknitt commented Oct 3, 2022

Yes, wanted to have it in here first, will add it to ReactDOMStyle.res, too.

(At some later point we should probably deprecate ReactDOMStyle.make and people should just construct style records directly.)

@cknitt cknitt merged commit ac72301 into rescript-lang:10.1_release Oct 3, 2022
@cknitt cknitt deleted the backdrop-filter branch October 3, 2022 05:05
@mununki
Copy link
Member

mununki commented Oct 3, 2022

(At some later point we should probably deprecate ReactDOMStyle.make and people should just construct style records directly.)

That would be perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mununki mununki mununki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @mununki