Skip to content

setup-ocaml 2.0.6 supports macOS ARM now #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

setup-ocaml 2.0.6 supports macOS ARM now #5625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,12 @@ jobs:
submodules: true

- name: Use OCaml ${{matrix.ocaml_compiler}}
if: runner.name != 'macos-arm'
uses: ocaml/setup-ocaml@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious this does not need to change. Not very transparent.
It means things will change behind your back in future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's because we were using @v2 and not @v2.0.5.
In theory, following semantic versioning, any changes happening behind our back should be non-breaking.

For the other actions in this file, we are also specifying the major version only.
I would keep it this way. In case any problem arises at some point in the future, we can still specify the exact version where needed.

with:
ocaml-compiler: ${{matrix.ocaml_compiler}}
opam-pin: false
opam-depext: false

- name: Use OCaml ${{matrix.ocaml_compiler}} (macOS ARM)
if: runner.name == 'macos-arm'
uses: AbstractMachinesLab/setup-ocaml@arm-support
with:
ocaml-compiler: ${{matrix.ocaml_compiler}}
opam-pin: false
opam-depext: false

- name: Use Node.js
uses: actions/setup-node@v3
with:
Expand Down