setup-ocaml 2.0.6 supports macOS ARM now #5625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Aug 31, 2022
| @@ -34,21 +34,12 @@ jobs: | |||
| submodules: true | |||
|
|
|||
| - name: Use OCaml ${{matrix.ocaml_compiler}} | |||
| if: runner.name != 'macos-arm' | |||
| uses: ocaml/setup-ocaml@v2 | |||
There was a problem hiding this comment.
Curious this does not need to change. Not very transparent.
It means things will change behind your back in future.
There was a problem hiding this comment.
Right, that's because we were using @v2 and not @v2.0.5.
In theory, following semantic versioning, any changes happening behind our back should be non-breaking.
For the other actions in this file, we are also specifying the major version only.
I would keep it this way. In case any problem arises at some point in the future, we can still specify the exact version where needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify ci.yml, setup-ocaml fork is no longer needed.