Skip to content

remove some warnings #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

aspeddro
Copy link
Collaborator

  • Remove esbuild-loader. - Next warning
    • Next use swc internally.
  • Add key for <li> elements - React warning
  • Rename prop hrefRel to hrefrel in Next.Link - React warning
  • Fix warnings with deprecated tailwindcss = tailwindcss warning

For some reason esbuild-loader are generated some warnings when run npm run dev

<w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'Compilation/modules|/home/pedro/Desktop/projects/rescript-
lang.org/node_modules/next/dist/compiled/@next/react-refresh-utils/dist/loader.js!/home/pedro/Desktop/projects/rescript-lang.org/node_mod
ules/next/dist/build/webpack/loaders/next-swc-loader.js??ruleSet[1].rules[6].oneOf[2].use[1]!/home/pedro/Desktop/projects/rescript-lang.o
rg/node_modules/esbuild-loader/dist/index.cjs??ruleSet[1].rules[11].use[0]!/home/pedro/Desktop/projects/rescript-lang.org/pages/_app.js':
 No serializer registered for ProvidedDependency
<w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> Array { 9 items } -> Provid
edDependency
<w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'Compilation/modules|/home/pedro/Desktop/projects/rescript-
lang.org/node_modules/next/dist/build/webpack/loaders/next-swc-loader.js??ruleSet[1].rules[6].oneOf[2].use[0]!/home/pedro/Desktop/project
s/rescript-lang.org/node_modules/esbuild-loader/dist/index.cjs??ruleSet[1].rules[10].use[0]!/home/pedro/Desktop/projects/rescript-lang.or
g/pages/_app.js': No serializer registered for ProvidedDependency
<w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> Array { 9 items } -> Provid
edDependency

- Remove esbuild-loader.
- Fix key for `<li>` elements
- Rename prop hrefRel in Next.Link
Copy link

vercel bot commented Feb 24, 2024

@aspeddro is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Feb 26, 2024

Was that rule from before the latest Next upgrade?
Edit: So it was from your upgrade. Then I guess it's not needed anymore now?

@aspeddro
Copy link
Collaborator Author

aspeddro commented Feb 26, 2024

Probably after #723, but I don't remember seeing these warnings in the update. However, it is good to get rid of configuration that is not necessary.

@fhammerschmidt fhammerschmidt merged commit 2638333 into rescript-lang:master Feb 26, 2024
@fhammerschmidt
Copy link
Member

This unfortunately broke the playground, so I reverted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants