Skip to content

Upgrade to NextJS 13 / MDX v2 / Tailwindcss v3 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Oct 24, 2023

Conversation

aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented Oct 8, 2023

  • Frontmatter parser fixed
  • Getting rid of the CommonJS
  • Tailwindcss v3
  • Update ReScript to 10.1.4

Special thanks to @JiaeK for starting this

JiaeK and others added 30 commits January 4, 2023 16:42
- Update next-transpile-modules to version 9
- Remove .babelrc file
- Remove esbuild-loader, path, fs, target, future from next.config.js
- Add SWC in next.config.js
* Update next-transpile-modules to v.10
* Switch to @next/mdx
* Adjust transpileModules
* Remove child <a> tags of <link>
…-lang.org into nextjs-12"

This reverts commit 5334930, reversing
changes made to 25d4a35.
@@ -9,7 +9,7 @@ canonical: "/docs/manual/latest/type"
Types are the highlight of ReScript! They are:
- **Strong**. A type can't change into another type. In JavaScript, your variable's type might change when the code runs (aka at runtime). E.g. a `number` variable might change into a `string` sometimes. This is an anti-feature; it makes the code much harder to understand when reading or debugging.
- **Static**. ReScript types are erased after compilation and don't exist at runtime. Never worry about your types dragging down performance. You don't need type info during runtime; we report all the information (especially all the type errors) during compile time. Catch the bugs earlier!
- **Sound**. This is our biggest differentiator versus many other typed languages that compile to JavaScript. Our type system is guaranteed to **never** be wrong. Most type systems make a guess at the type of a value and show you a type in your editor that's sometimes incorrect. We don't do that. We believe that a type system that is sometimes incorrect can end up dangerous due to expectation mismatches.
- **Sound**. This is our biggest differentiator versus many other typed languages that compile to JavaScript. Our type system is guaranteed to **never** be wrong. Most type systems make a guess at the type of a value and show you a type in your editor that's sometime incorrect. We don't do that. We believe that a type system that is sometime incorrect can end up being dangerous due to expectation mismatches.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original sentence was correct.

Suggested change
- **Sound**. This is our biggest differentiator versus many other typed languages that compile to JavaScript. Our type system is guaranteed to **never** be wrong. Most type systems make a guess at the type of a value and show you a type in your editor that's sometime incorrect. We don't do that. We believe that a type system that is sometime incorrect can end up being dangerous due to expectation mismatches.
- **Sound**. This is our biggest differentiator versus many other typed languages that compile to JavaScript. Our type system is guaranteed to **never** be wrong. Most type systems make a guess at the type of a value and show you a type in your editor that's sometimes incorrect. We don't do that. We believe that a type system that is sometimes incorrect can end up dangerous due to expectation mismatches.

Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work @aspeddro. Thanks for the contribution!

@ryyppy ryyppy merged commit c0a48a8 into rescript-lang:master Oct 24, 2023
@aspeddro aspeddro mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants