Skip to content

[Beta] Upgrade Sandpack #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 10, 2022
Merged

[Beta] Upgrade Sandpack #5033

merged 6 commits into from
Sep 10, 2022

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Sep 10, 2022

Resubmit of #4843 with a few fixes on top.

@github-actions
Copy link

github-actions bot commented Sep 10, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 82.38 KB (🟢 -2.03 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@harish-sethuraman
Copy link
Collaborator

Did this just introduce a horizontal scroll? https://beta-reactjs-6gh2p4qfo-fbopensource.vercel.app/learn/managing-state

@gaearon
Copy link
Member Author

gaearon commented Sep 10, 2022

yeah i think something here is doing this...

@gaearon
Copy link
Member Author

gaearon commented Sep 10, 2022

something's wrong with the layout of long lines in sandboxes. they don't fit anymore.

@gaearon
Copy link
Member Author

gaearon commented Sep 10, 2022

seems fine. let's fix forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants