Skip to content

[Beta] Fix navigation sticky failure #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 10, 2022
Merged

Conversation

zqran
Copy link
Contributor

@zqran zqran commented Sep 10, 2022

In the current Doc, the sticky of the navigation bar on both sides is invalid.
Associated with #5028

@github-actions
Copy link

github-actions bot commented Sep 10, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 82.41 KB (🟡 +15 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@gaearon
Copy link
Member

gaearon commented Sep 10, 2022

Oh interesting. I guess this would work too. I did 8f8bcb9. Not sure I feel strongly about which fix to take.

@gaearon
Copy link
Member

gaearon commented Sep 10, 2022

Hm. My fix is actually breaking other stuff.

@zqran
Copy link
Contributor Author

zqran commented Sep 10, 2022

My fix is according to your description in #5028, it may not be considered very comprehensive.

@@ -76,6 +76,12 @@
margin: 0;
}

@media screen and (max-width: 768px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 1024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be. I will fix it

@gaearon
Copy link
Member

gaearon commented Sep 10, 2022

Hm, sticky in sandboxes is still broken by #5033. Not sure how.

@gaearon
Copy link
Member

gaearon commented Sep 10, 2022

ok i fixed them in acc8dcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants