-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Beta] Fix navigation sticky failure #5032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
Page | Size (compressed) |
---|---|
global |
82.41 KB (🟡 +15 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Oh interesting. I guess this would work too. I did 8f8bcb9. Not sure I feel strongly about which fix to take. |
Hm. My fix is actually breaking other stuff. |
My fix is according to your description in #5028, it may not be considered very comprehensive. |
beta/src/styles/index.css
Outdated
@@ -76,6 +76,12 @@ | |||
margin: 0; | |||
} | |||
|
|||
@media screen and (max-width: 768px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 1024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be. I will fix it
Hm, sticky in sandboxes is still broken by #5033. Not sure how. |
ok i fixed them in acc8dcf |
In the current Doc, the sticky of the navigation bar on both sides is invalid.
Associated with #5028