Take system's theme for the beta site #4022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work for the initial render. It will flash. |
|
Shall I add an IIFE to the document then? Like you had done in over reacted site? https://github.com/gaearon/overreacted.io/blob/master/src/html.js#L21 |
|
Seems like this doesn’t work for sandboxes? |
|
Do you mean for the sandpack component in the site? 🤔 |
|
Oh I see. That's in #4019. We need to figure out what to get in first. |
|
When I load a preview on this branch with initial Dark more, I see the toggle flash. |
|
What's happening here is that the SSR content always assumes the theme is light. You should either hide the toggle or show the correct toggle icon with CSS. |
|
Will work on it and push changes for toggle. |
|
I think I'll take it over from here. Thanks! |
gaearon
force-pushed
the
take-system-theme
branch
from
1e31ba8 to
afc7965
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has dark theme as preferred color scheme. apply dark mode.
It was a todo in the code 😄
// TODO: respect system pref