Skip to content

[Beta] Dark more tweaks #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2021
Merged

[Beta] Dark more tweaks #4019

merged 3 commits into from
Nov 4, 2021

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Oct 28, 2021 •
edited
Loading

Work in progress

Adds dark mode for code blocks:

Screenshot 2021-10-28 at 22 42 02

The light theme is tbd. (The one in this branch is kind of placeholder.)

Also fixes #3965 (comment).

  • Dark mode toggles code block color
  • Fix horizontal overscroll overlapping issue on mobile
  • Persist color choice / use system prefs
  • Figure out which light theme we want to go with

@gaearon gaearon mentioned this pull request Oct 28, 2021
Closed
This was referenced Oct 29, 2021
Closed
Closed
@amitojsingh366
Copy link

hey @gaearon could you please checkout #4023 i've added dark mode persisting, smooth transitions and also made a few components use dark mode

@gaearon gaearon mentioned this pull request Nov 4, 2021
Merged
@gaearon gaearon merged commit d51f706 into main Nov 4, 2021
@gaearon gaearon added the beta label Nov 6, 2021
@rickhanlonii rickhanlonii deleted the dark-tweaks branch April 29, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salazarm salazarm salazarm approved these changes

Assignees
No one assigned
Labels
beta CLA Signed React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaearon @amitojsingh366 @salazarm @facebook-github-bot @lebo