Skip to content

Allow to pass DOM object as parent selector. #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow to pass DOM object as parent selector. #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions lib/assets/javascripts/react_ujs.js.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,29 @@
// `data-react-class` DOM elements
findDOMNodes: function(searchSelector) {
// we will use fully qualified paths as we do not bind the callbacks
var selector;
if (typeof searchSelector === 'undefined') {
var selector = '[' + window.ReactRailsUJS.CLASS_NAME_ATTR + ']';
} else {
var selector = searchSelector + ' [' + window.ReactRailsUJS.CLASS_NAME_ATTR + ']';
var selector, parent;

switch (typeof searchSelector) {
case 'undefined':
selector = '[' + window.ReactRailsUJS.CLASS_NAME_ATTR + ']';
parent = document;
break;
case 'object':
selector = '[' + window.ReactRailsUJS.CLASS_NAME_ATTR + ']';
parent = searchSelector;
break;
case 'string':
selector = searchSelector + '[' + window.ReactRailsUJS.CLASS_NAME_ATTR + ']';
parent = document;
break
default:
break;
}

if ($) {
return $(selector);
return $(selector, parent);
} else {
return document.querySelectorAll(selector);
return parent.querySelectorAll(selector);
}
},

Expand Down