Allow to pass DOM object as parent selector. #340
Conversation
Extend possibility of `findDOMNodes` and as a consequence `mountComponents`. It allows to use it with an element which was inserted to the DOM tree without react.js. Example:
```
$(document).on('nested:fieldAdded', function(e) {
window.ReactRailsUJS.mountComponents(e.target);
});
```
With backward compatibility, of course.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
👍 nice feature! Can you investigate that failing test? It looks like it passes on master. Does it fail locally? Also, could you add a test for this new behavior? I think you could base your new test off of the existing one for mounting & unmounting by selector strings. You can see that the test clicks some buttons and makes sure that components are unmounted and re-mounted: https://github.com/reactjs/react-rails/blob/master/test/react/rails/view_helper_test.rb#L135-L136 The buttons are defined in this Rails view: https://github.com/reactjs/react-rails/blob/1c03b00b8105c78fbf674abe34be4941084bede4/test/dummy/app/views/pages/show.html.erb So, I think you could make 2 new buttons which call those functions with DOM elements instead of strings. Then, in your test, click those buttons and make sure components are unmounted and re-mounted, just like the existing test. |
|
I fixed and added tests for this branch here: master...ximus:support-dom-node-context let me know what you want me to do with it |
|
Awesome, please open a new Pull Request! If we merge that one, then we can close this one. |
|
Thanks, @ximus! |
|
closed by #358 , Thanks for getting this started! |
Extend possibility of
findDOMNodesand as a consequencemountComponents. It allows to use it with an element which was inserted to the DOM tree without react.js. Example:With backward compatibility, of course.