-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add more information about deep link for expo projects #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,12 +40,50 @@ const SimpleApp = createAppContainer(createStackNavigator({...})); | |
// on Android, the URI prefix typically contains a host in addition to scheme | ||
// on Android, note the required / (slash) at the end of the host property | ||
const prefix = Platform.OS == 'android' ? 'mychat://mychat/' : 'mychat://'; | ||
// in Expo projects you can do the following to get the URI prefix | ||
const prefix = Expo.Linking.makeUrl('/'); | ||
|
||
const MainApp = () => <SimpleApp uriPrefix={prefix} />; | ||
``` | ||
|
||
## Set up with Expo projects | ||
|
||
you need to specify a scheme for your app. You can register for a scheme in your `app.json` by adding a string under the scheme key: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should capitalize the first word in the paragraph, so "You need" rather than "you need" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤦🏾♂️ |
||
|
||
```json | ||
{ | ||
"expo": { | ||
"scheme": "mychat" | ||
} | ||
} | ||
``` | ||
### iOS | ||
|
||
To test the URI on the simulator (Expo client app ), run the following: | ||
|
||
``` | ||
xcrun simctl openurl booted [ put your URI prefix in here ] | ||
|
||
// for example | ||
|
||
xcrun simctl openurl booted exp://127.0.0.1:19004/--/chat/Eric | ||
|
||
``` | ||
|
||
|
||
### Android | ||
|
||
To test the intent handling in Android (Expo client app ), run the following: | ||
|
||
``` | ||
adb shell am start -W -a android.intent.action.VIEW -d "[ put your URI prefix in here ]" com.simpleapp | ||
|
||
// for example | ||
|
||
adb shell am start -W -a android.intent.action.VIEW -d "exp://127.0.0.1:19004/--/chat/Eric" com.simpleapp | ||
|
||
``` | ||
|
||
Read the [Expo linking guide](https://docs.expo.io/versions/latest/guides/linking.html) for more information about how to configure linking in projects built with Expo. | ||
|
||
## Set up with `react-native init` projects | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to have an entirely separate section for expo projects / vanilla react native projects, and just repeat this entire code example in both sections but with the prefix line that is relevant to the platform. it's a bit cleaner when you can just pick the section relevant to you and follow that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, thanks! I'll do that.