add more information about deep link for expo projects #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation ready! Built with commit cdb636d |
brentvatne
reviewed
Dec 28, 2018
docs/deep-linking.md
Outdated
|
|
||
| const MainApp = () => <SimpleApp uriPrefix={prefix} />; | ||
| ``` | ||
|
|
||
| ## Set up with Expo projects | ||
|
|
||
| you need to specify a scheme for your app. You can register for a scheme in your `app.json` by adding a string under the scheme key: |
There was a problem hiding this comment.
should capitalize the first word in the paragraph, so "You need" rather than "you need"
brentvatne
reviewed
Dec 28, 2018
| @@ -40,12 +40,50 @@ const SimpleApp = createAppContainer(createStackNavigator({...})); | |||
| // on Android, the URI prefix typically contains a host in addition to scheme | |||
| // on Android, note the required / (slash) at the end of the host property | |||
| const prefix = Platform.OS == 'android' ? 'mychat://mychat/' : 'mychat://'; | |||
| // in Expo projects you can do the following to get the URI prefix | |||
| const prefix = Expo.Linking.makeUrl('/'); | |||
There was a problem hiding this comment.
we might want to have an entirely separate section for expo projects / vanilla react native projects, and just repeat this entire code example in both sections but with the prefix line that is relevant to the platform. it's a bit cleaner when you can just pick the section relevant to you and follow that
There was a problem hiding this comment.
yes, thanks! I'll do that.
brentvatne
requested changes
Dec 28, 2018
|
done :) |
|
💯 |
brentvatne
approved these changes
Dec 29, 2018
|
added a bit more clarification on the expo stuff :) |
|
cool! thanks for add that awesome clarification. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.