Ensure bundler is required when used #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring.gemfile is using bundler, the require is needed in certain cases in which Bundler is not already loaded. Specifically when spring is loaded via Spring::ApplicationManager the #start_child method wraps the call inside Bundler.with_original_env restoring a RUBYOPT env variable without the bundler require. That in turn causes errors like: /Users/elia/.asdf/installs/ruby/2.7.1/lib/ruby/gems/2.7.0/gems/spring-2.1.1/lib/spring/configuration.rb:10:in `gemfile': uninitialized constant #<Class:Spring>::Bundler (NameError)
elia
force-pushed
the
missing-bundler-require
branch
from
f222215 to
9f7d072
Compare
|
Sometimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring.gemfileis using bundler, the require is needed in certain cases in which Bundler is not already loaded.Specifically when spring is loaded via
Spring::ApplicationManagerthe#start_childmethod wraps the call insideBundler.with_original_envrestoring aRUBYOPTenv variable without the bundler require. That, in turn, causes errors like:Fixes #624