Lazily load fileutils and tmpdir #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes some fileutils redefintion warnings that happen when you boot a
rails
application that usesspring
on a system with a defaultfileutils
version, and a higher version of thefileutils
gem available as well. This can happen, for example, on ruby 2.6.Repro instructions are here: ruby/fileutils#22 (comment).
The short explanation of why this happens is that
spring
loads without usingbundler
, so the fileutilsrequire
uses rubygems version ofKernel.require
which automatically activates the latest version of the corresponding gem if arequire
argument matches a default gem (likefileutils
). Thenrails
itself also requiresfileutils
, but at that pointbundler
is already loaded, andbundler
does not changeKernel.require
at all, hence the default version offileutils
is chosen this time.By lazily loading
fileutils
, we make sure thatbundler
is always loaded beforefileutils
, and thus the version that ends up being required is consistent.The explanation of why also lazily loading
tmpdir
is becausetmpdir
also loadsfileutils
.