rabbitmq-java-client #120: unsynchronized access to recordedBindings gives undesired results #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gives undesired results
|
Other similar methods synchronise on the specific fields they mutate. Can we make this synchronise on |
|
I'm sure it's possible; however, all of the other methods which are currently synchronized would need to change to the field-synchronized strategy as well. There's sort of a mix of different synchronization styles in play currently. |
|
Ah, yes, there are |
michaelklishin
added a commit
that referenced
this pull request
Dec 30, 2015
rabbitmq-java-client #120: unsynchronized access to recordedBindings gives undesired results
|
Yeah, it might be slightly less-than-ideal, but probably a bigger project to revise how concurrency works in that particular class. |
|
@spatula75 agreed. Thank you! |
stream-iori
pushed a commit
to stream-iori/rabbitmq-java-client
that referenced
this pull request
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is to simply make
removeBindingsWithDestinationa synchronized method (like the other methods which access recordedBindings).