Merge pull request #121 from spatula75/rabbitmq-java-client-120

michaelklishin · michaelklishin · commit 500120bf303f · 2015-12-30T21:21:29.000+03:00
rabbitmq-java-client #120: unsynchronized access to recordedBindings gives undesired results
diff --git a/src/com/rabbitmq/client/impl/recovery/AutorecoveringConnection.java b/src/com/rabbitmq/client/impl/recovery/AutorecoveringConnection.java
@@ -766,7 +766,7 @@ boolean hasMoreConsumersOnQueue(Collection<RecordedConsumer> consumers, String q
         return result;
     }
 
-    Set<RecordedBinding> removeBindingsWithDestination(String s) {
+    synchronized Set<RecordedBinding> removeBindingsWithDestination(String s) {
         Set<RecordedBinding> result = new HashSet<RecordedBinding>();
         for (Iterator<RecordedBinding> it = this.recordedBindings.iterator(); it.hasNext(); ) {
             RecordedBinding b = it.next();

Original file line number	Diff line number	Diff line change
`@@ -766,7 +766,7 @@ boolean hasMoreConsumersOnQueue(Collection<RecordedConsumer> consumers, String q`
`766`	`766`	`return result;`
`767`	`767`	`}`
`768`	`768`
`769`		`- Set<RecordedBinding> removeBindingsWithDestination(String s) {`
	`769`	`+ synchronized Set<RecordedBinding> removeBindingsWithDestination(String s) {`
`770`	`770`	`Set<RecordedBinding> result = new HashSet<RecordedBinding>();`
`771`	`771`	`for (Iterator<RecordedBinding> it = this.recordedBindings.iterator(); it.hasNext(); ) {`
`772`	`772`	`RecordedBinding b = it.next();`