-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update Compiled Autograd tutorial with images #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3108
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 1d69204 with merge base 0c5e2c6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is amazing! Thanks for taking the time to do these improvements!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, otherwise looks good - let's wait for the preview to check.
Seems to have rendered correctly: https://docs-preview.pytorch.org/pytorch/tutorials/3108/intermediate/compiled_autograd_tutorial.html I'll apply the suggestions |
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Fixes #3107
Description
I'm replacing the long string errors with annotated images, with some minor additions:
e.g.
Before

After

Checklist