Add explanation video to torch.autograd tutorial
#2625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2625
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cb42710 with merge base 62468fa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
reviewed
Oct 26, 2023
| @@ -2,6 +2,12 @@ | |||
| """ | |||
| A Gentle Introduction to ``torch.autograd`` | |||
| --------------------------------- | |||
| **Video by**: `Elliot Waite <https://www.youtube.com/@elliotwaite>`_ | |||
There was a problem hiding this comment.
Can we please not embed a video as we generally only embed videos from the official PyTorch youtube channel. Please add a link under Further readings on line 319 at the bottom of this tutorial. Thank you for understanding!
There was a problem hiding this comment.
Certainly, I've updated the PR. Let me know if I should make any changes to the link text.
malfet
approved these changes
Oct 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Description
This PR adds an explanation video to the A Gentle Introduction to
torch.autogradpage.Checklist