Add Video #1025
Add Video #1025
Conversation
|
✔️ Deploy Preview for pytorch-tutorials-preview ready! 🔨 Explore the source changes: 0489135 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/61414ae4f40b3d00074cc796 😎 Browse the preview: https://deploy-preview-1025--pytorch-tutorials-preview.netlify.app |
|
These error messages in the log file do not seem very specific: It may have failed for a reason unrelated to the changed file. Perhaps you could try rerunning the checks. Do you see an option to do that? |
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@PradeepSinghMakwana, it looks like this pull request might be able to be merged soon, but I think you'll have to sign Facebook's CLA (contributor license agreement) first, as mention by the @facebook-github-bot above. Here's the link again to where you can sign it: https://code.facebook.com/cla. Let me know if you have any questions about this. I recently also signed the CLA myself for a different pull request I submitted. |
|
@elliotwaite Thanks. But, I am sorry. I broke my leg. It will take me
almost 1-2 week to reach my computer. I will try my best. I will also sign
for Facebook CLA
…On Wed, 28 Apr 2021 12:27 AM Elliot Waite, ***@***.***> wrote:
@PradeepSinghMakwana <https://github.com/PradeepSinghMakwana>, it looks
like this pull request might be able to be merged soon, but I think you'll
have to sign Facebook's CLA (contributor license agreement) first, as
mention by the @facebook-github-bot
<https://github.com/facebook-github-bot> above. Here's the link again to
where you can sign it: https://code.facebook.com/cla. Let me know if you
have any questions about this. I recently also signed the CLA myself for a
different pull request I submitted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1025 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7EXBKLP7N2CG45RD7P7OTTK4CLPANCNFSM4N4HNKWA>
.
|
|
@PradeepSinghMakwana, oh dang, sorry to hear about your broken leg. I hope you feel better. No worries about the delay, whenever you get around to it is fine with me. Thanks for the update. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@elliotwaite Thanks. I am back. I signed for the Facebook CLA, but still windows test is failing. I don't see anything specific to my pull request. Can you help? |
|
Hey @PradeepSinghMakwana, glad to hear you're back. It looks like the failure was unrelated to the changes in this pull request. I've encountered this situation before and just rerunning the checks at a later time resolved the issue for me. I would suggest trying to just rerun the checks. I forget how I reran the checks, but you can see if any of the suggestions here will work for you: https://stackoverflow.com/questions/52408592/how-to-relaunch-github-check-without-pushing-new-commits/52412240 |
|
Hmm, looks like the same error is still occurring. Maybe's there's currently an issue with the CI. I'd suggest just retrying the checks at another time. Maybe after a few days. |
|
@PradeepSinghMakwana, looks like all the checks have finally passed! Thanks for following up on this. Hopefully, someone will now be able to review it. |
|
@holly1238 Could you please help with the poster again to merge this PR? I found the video really, from my heart, useful for beginners like me to understand the topic with the beautifully graphed materials at a careful pace. Thank for your helps before we need you again. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
This PR can be closed. It was replaced by: #2625 |
No description provided.