Fix a display bug which cannot update figure correctly #2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
LGTM |
|
Sure! |
|
@Yichi-Lionel-Cheung can you please resolve the conflict? Thanks! |
|
Hi @svekars , conflict resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using notebook such as colab and local jupyter where
is_ipython == True, the training procedure is not shown correctly. The figure is closed too fast to observe sinceclear_output(wait=True)is always activated.Excanging
display.display(plt.gcf())anddisplay.clear_output(wait=True)could fix the bug.In addition, after training the model, the resulting figure contains all episodes shall be displaied.
cc @vmoens @nairbv