[ao] fixing tutorials #2140
Merged
[ao] fixing tutorials #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137
Closed
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svekars
reviewed
Dec 5, 2022
Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137
…h/tutorials into 1_fx_quantization_mapping
|
thanks for your help cleaning up these tutorials @svekars, i've made those suggested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: fixing tutorial to have example_inputs and QConfigMapping.
note: the quantization guide leaves example_inputs non initialized that code doesn't seem intended to run and we don't know what teh model is supposed to be.
Test Plan: for fx_graph_mode_ptq_static.rst and
fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified.
for the quant_guide no explicit testing was done
Reviewers:
Subscribers:
Tasks:
Tags:
Pull Request resolved: #2137