[ao] fixing tutorials #2137
Closed
[ao] fixing tutorials #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 2, 2022
Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137
|
Hi @HDCharles! Can you please submit a regular PR, not with ghstack! Thanks! |
jerryzh168
reviewed
Dec 2, 2022
| .. code:: python | ||
|
|
||
| qconfig_mapping = (QConfigMapping() | ||
| .set_global(qconfig?) # qconfig? means either a valid qconfig or None |
There was a problem hiding this comment.
maybe let's call it qconfig_opt or something, I feel qconfig? is a bit weird to write in code
jerryzh168
reviewed
Dec 2, 2022
| model_fp32, | ||
| qconfig_dict, | ||
| model_fp32, | ||
| qconfig_mapping, |
There was a problem hiding this comment.
nit: this one also needs example_inputs now
jerryzh168
reviewed
Dec 2, 2022
| qconfig_dict, | ||
| model_fp32, | ||
| qconfig_mapping, | ||
| example_inputs, |
There was a problem hiding this comment.
do we want to define an example_inputs here?
There was a problem hiding this comment.
we don't define the other things so i think its fine
HDCharles
added a commit
that referenced
this pull request
Dec 4, 2022
Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137
Merged
ok, did that: #2140 (closing this) |
HDCharles
added a commit
that referenced
this pull request
Dec 5, 2022
Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137
HDCharles
added a commit
that referenced
this pull request
Dec 5, 2022
* [ao] fixing tutorials Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137 * Fix typo "tesors" (#2138) * [ao] fixing tutorials Summary: fixing tutorial to have example_inputs and QConfigMapping Test Plan: for fx_graph_mode_ptq_static.rst and fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the latter could be run exactly while the former required a slight modification since I didn't had a different version of the imagenet dataset but only the dataloaders had to be modified. for the quant_guide no explicit testing was done Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d142b2f Pull Request resolved: #2137 Co-authored-by: Svetlana Karslioglu <svekars@fb.com> Co-authored-by: Alex Triapitsyn <atryapa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: fixing tutorial to have example_inputs and QConfigMapping
Test Plan:
built tutorials
for fx_graph_mode_ptq_static.rst and
fx_graph_mode_ptq_dynamic.py I pasted and ran the script to verify that it ran, the
latter could be run exactly while the former required a slight
modification since I had a different version of the imagenet
dataset but only the dataloaders had to be modified.
for the quant_guide no explicit testing was done
Reviewers:
Subscribers:
Tasks:
Tags: