[ci] Run all python files in the *_source folders #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
clee2000
changed the title
ZainRizvi
approved these changes
Sep 12, 2022
| for filename in $(find docs/beginner docs/intermediate docs/advanced docs/recipes docs/prototype -name '*.html'); do | ||
| file_basename=$(basename $filename .html) | ||
| if [[ ! " ${FILES_TO_RUN} " =~ " ${file_basename} " ]]; then | ||
| echo "removing $filename" |
There was a problem hiding this comment.
fyi, bash scripts can have functions too :)
.jenkins/validate_tutorials_built.py
Outdated
| OK_TO_NOT_RUN = [ | ||
| "beginner/basics/intro.html", # no code | ||
| ] | ||
| # files not ending in "tutorial.py" are not run by sphinx (see sphinx_gallery_conf in conf.py), |
There was a problem hiding this comment.
Does this mean we don't actually have any tutorials we currently know to be broken?
There was a problem hiding this comment.
yes, or at least i am not aware of them
|
Hmm, wouldn't those renames break consistency? |
clee2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run all python files in the *_source folders.
Make build.sh slightly less verbose