Skip to content

Commit 381feb7

Browse files
committed
comment
1 parent 9de4108 commit 381feb7

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

.jenkins/validate_tutorials_built.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55

66
REPO_ROOT = Path(__file__).parent.parent
77

8-
# files that are ok to have 0 min 0 sec time, probably because they don't have any python code
9-
OK_TO_NOT_RUN = [
10-
"beginner/basics/intro.html", # no code
11-
]
8+
# files not ending in "tutorial.py" are not run by sphinx (see sphinx_gallery_conf in conf.py),
9+
# so we create a list of files that look like tutorials but aren't run due to this.
10+
#
11+
# For every tutorial on this list, we should determine if it is ok to not run the tutorial (add a comment after
12+
# the file name to explain why, like how intro.html is now), or fix the tutorial (change the name to end with
13+
# "tutorial.py" and remove it from this list).
1214

13-
# when the tutorial is fixed, remove it from this list
14-
KNOWN_BAD = [
15+
NOT_RUN = [
16+
"beginner/basics/intro.html", # no code
1517
"beginner/translation_transformer.html",
1618
"beginner/profiler.html",
1719
"beginner/saving_loading_models.html",
@@ -84,7 +86,7 @@ def main() -> None:
8486
"Total running time of the script: ( 0 minutes 0.000 seconds)"
8587
in elem.text
8688
and not any(
87-
html_file_path.match(file) for file in KNOWN_BAD + OK_TO_NOT_RUN
89+
html_file_path.match(file) for file in NOT_RUN
8890
)
8991
):
9092
did_not_run.append(html_file_path.as_posix())

0 commit comments

Comments
 (0)