Skip to content

cpp_tests: Switch to only use conda-forge and add back ffmpeg 6 #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

cpp_tests: Switch to only use conda-forge and add back ffmpeg 6 #658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c21d6c
cpp_tests: Switch to only use conda-forge
traversaro Apr 28, 2025
cad08c0
Add comment
NicolasHug Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/cpp_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,19 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO put back 6.1.1. See
# https://github.com/pytorch/torchcodec/issues/518
ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '7.0.1']
ffmpeg-version-for-tests: ['4.4.2', '5.1.2', '6.1.1', '7.0.1']
steps:
- name: Check out repo
uses: actions/checkout@v3
- name: Setup conda env
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
miniconda-version: "latest"
# Using miniforge instead of miniconda ensures that the default
# conda channel is conda-forge instead of main/default. This ensures
# ABI consistency between dependencies:
# https://conda-forge.org/docs/user/transitioning_from_defaults/
miniforge-version: latest
activate-environment: test
python-version: '3.12'
- name: Update pip
Expand Down