cpp_tests: Switch to only use conda-forge and add back ffmpeg 6 #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
NicolasHug
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Thank you for the PR @traversaro !
This LGTM, I added a small comment to document why this was needed. I also opened #659 to make sure the changes in this PR are load-bearing and that the C++/FFmpeg6 tests weren't already magically resolved. #659 is failing as expected, so this PR is a fix.
Q for @atalman:
This PR updates the cpp_test.yaml config, but we probably will want to update all the other configs, including those where we build the wheels from. Do you know if there is any issue in using miniforge instead of miniconda in all of our configs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #518 .