Add betainc C implementation #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like you need to run pre-commit for auto-formatting |
|
Could you remove the comma after |
added 2 commits
June 4, 2024 16:33
|
Thanks, that also led me to realize I didn't set a code cache version. I set |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 80.76% 80.83% +0.07%
==========================================
Files 163 163
Lines 46941 46907 -34
Branches 11499 11470 -29
==========================================
+ Hits 37912 37918 +6
+ Misses 6786 6772 -14
+ Partials 2243 2217 -26
|
ricardoV94
reviewed
Jun 5, 2024
pytensor/scalar/math.py
Outdated
| raise NotImplementedError("type not supported", type) | ||
|
|
||
| def c_code_cache_version(self): | ||
| return (0, 0, 1) |
ricardoV94
reviewed
Jun 5, 2024
pytensor/scalar/math.py
Outdated
Comment on lines
1506
to
1507
| if node.inputs[0].type in float_types: | ||
| return f"""{z} = BetaInc({a}, {b}, {x});""" |
There was a problem hiding this comment.
Don't all the inputs need to be floats?
|
Sorry for the delay, I addressed your comments. Thanks for catching the input check. |
ricardoV94
approved these changes
Jul 5, 2024
|
Sorry for the delay @arthus701 and thanks a lot |
11 tasks
ricardoV94
added a commit
to ricardoV94/pytensor
that referenced
this pull request
Jul 9, 2024
This reverts commit 31bf682.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed over at #673, this adds a C-implementation to BetaInc.
Related Issue
Type of change