Skip to content

Bump PyTensor dependency #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 4, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7400.org.readthedocs.build/en/7400/

@ricardoV94 ricardoV94 added no releasenotes Skipped in automatic release notes generation dependencies Pull requests that update a dependency file labels Jul 4, 2024
@ricardoV94 ricardoV94 requested a review from twiecki July 4, 2024 08:16
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dep_2_24 branch 2 times, most recently from 4cdedb5 to a6d276d Compare July 4, 2024 09:10
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dep_2_24 branch from 31ec494 to 5194900 Compare July 4, 2024 10:14
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dep_2_24 branch from 5194900 to 7b12b91 Compare July 8, 2024 16:00
@ricardoV94
Copy link
Member Author

ricardoV94 commented Jul 9, 2024

I think the new betainc C implementation from: pymc-devs/pytensor#798 has precision issues.

pymc-devs/pytensor#906

@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dep_2_24 branch 3 times, most recently from 6d58177 to c2da0ce Compare July 11, 2024 13:07
@ricardoV94 ricardoV94 force-pushed the bump_pytensor_dep_2_24 branch from c2da0ce to 15f139e Compare July 11, 2024 13:14
@ricardoV94 ricardoV94 merged commit 1b67888 into pymc-devs:main Jul 11, 2024
20 checks passed
@ricardoV94
Copy link
Member Author

Finally, this was a stubborn one!

@ricardoV94 ricardoV94 deleted the bump_pytensor_dep_2_24 branch July 11, 2024 13:46
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (2216b59) to head (15f139e).
Report is 94 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7400   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         103      103           
  Lines       17257    17258    +1     
=======================================
+ Hits        15908    15909    +1     
  Misses       1349     1349           
Files with missing lines Coverage Δ
pymc/distributions/distribution.py 91.58% <100.00%> (ø)
pymc/logprob/order.py 94.69% <100.00%> (+0.09%) ⬆️
pymc/logprob/rewriting.py 89.01% <ø> (-0.12%) ⬇️
pymc/logprob/tensor.py 77.60% <100.00%> (+0.18%) ⬆️
pymc/pytensorf.py 90.51% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no releasenotes Skipped in automatic release notes generation pytensor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants