Skip to content

Fix mixed dtype bug in gammaincc_grad #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 24, 2023

Introduced in #283

CC @tomicapretto

@ricardoV94 ricardoV94 added bug Something isn't working gradients labels May 24, 2023
@ricardoV94 ricardoV94 changed the title Fix mixed dtype bug in gammaincc_grad Fix mixed dtype bug in gammaincc_grad May 24, 2023
@ricardoV94 ricardoV94 force-pushed the fix_gammaincc_grad_bug branch 2 times, most recently from 820e710 to 9119461 Compare May 24, 2023 14:54
@ricardoV94 ricardoV94 force-pushed the fix_gammaincc_grad_bug branch from 9119461 to 1e80a10 Compare May 24, 2023 14:58
@codecov-commenter
Copy link

Codecov Report

Merging #318 (1e80a10) into main (203d919) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   80.50%   80.51%           
=======================================
  Files         154      154           
  Lines       45207    45214    +7     
  Branches    11048    11051    +3     
=======================================
+ Hits        36396    36402    +6     
  Misses       6610     6610           
- Partials     2201     2202    +1     
Impacted Files Coverage Δ
pytensor/link/jax/linker.py 94.87% <60.00%> (-5.13%) ⬇️
pytensor/link/jax/dispatch/random.py 96.07% <100.00%> (ø)
pytensor/link/numba/dispatch/random.py 98.83% <100.00%> (+0.02%) ⬆️
pytensor/scalar/math.py 89.25% <100.00%> (ø)

... and 1 file with indirect coverage changes

@tomicapretto
Copy link

Looks good! Thanks for the quick fix!

@ricardoV94 ricardoV94 merged commit db673f0 into pymc-devs:main May 24, 2023
@ricardoV94 ricardoV94 deleted the fix_gammaincc_grad_bug branch May 25, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gradients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants