Skip to content

⬆️ UPGRADE: Autoupdate pre-commit config #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Feb 5, 2024

Base PullRequest

default branch (https://github.com/pymc-devs/pymc/tree/main)

Command results

Details:
add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/build/src/bin
pip install pre-commit
Defaulting to user installation because normal site-packages is not writeable
Collecting pre-commit
  Downloading pre_commit-3.6.0-py2.py3-none-any.whl (204 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 204.0/204.0 KB 7.2 MB/s eta 0:00:00
Collecting virtualenv>=20.10.0
  Downloading virtualenv-20.25.0-py3-none-any.whl (3.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.8/3.8 MB 24.0 MB/s eta 0:00:00
Collecting nodeenv>=0.11.1
  Using cached nodeenv-1.8.0-py2.py3-none-any.whl (22 kB)
Requirement already satisfied: pyyaml>=5.1 in /usr/lib/python3/dist-packages (from pre-commit) (5.4.1)
Collecting cfgv>=2.0.0
  Using cached cfgv-3.4.0-py2.py3-none-any.whl (7.2 kB)
Collecting identify>=1.0.0
  Downloading identify-2.5.33-py2.py3-none-any.whl (98 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 98.9/98.9 KB 36.5 MB/s eta 0:00:00
Requirement already satisfied: setuptools in /usr/lib/python3/dist-packages (from nodeenv>=0.11.1->pre-commit) (59.6.0)
Collecting distlib<1,>=0.3.7
  Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 41.9 MB/s eta 0:00:00
Requirement already satisfied: platformdirs<5,>=3.9.1 in /usr/local/lib/python3.10/dist-packages (from virtualenv>=20.10.0->pre-commit) (4.2.0)
Collecting filelock<4,>=3.12.2
  Using cached filelock-3.13.1-py3-none-any.whl (11 kB)
Installing collected packages: distlib, nodeenv, identify, filelock, cfgv, virtualenv, pre-commit
Successfully installed cfgv-3.4.0 distlib-0.3.8 filelock-3.13.1 identify-2.5.33 nodeenv-1.8.0 pre-commit-3.6.0 virtualenv-20.25.0
pre-commit autoupdate || (exit 0);
[https://github.com/pre-commit/pre-commit-hooks] already up to date!
[https://github.com/lucianopaz/head_of_apache] already up to date!
[https://github.com/astral-sh/ruff-pre-commit] updating v0.1.14 -> v0.2.0
[https://github.com/MarcoGorelli/madforhooks] already up to date!
pre-commit run -a || (exit 0);
[INFO] Initializing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Installing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for merge conflicts............................................................Passed
check toml...........................................................................Passed
check yaml...........................................................................Passed
debug statements (python)............................................................Passed
fix end of files.....................................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing requirements-dev.txt

don't commit to branch...............................................................Passed
fix requirements.txt.................................................................Passed
trim trailing whitespace.............................................................Passed
Apply Apache 2.0 License.............................................................Passed
ruff.................................................................................Failed
- hook id: ruff
- exit code: 1

warning: The `--show-source` argument is deprecated. Use `--output-format=full` instead.
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'extend-per-file-ignores' -> 'lint.extend-per-file-ignores'
pymc/backends/report.py:37:18: RUF017 Avoid quadratic list summation
   |
35 |     @property
36 |     def _warnings(self):
37 |         chains = sum(self._chain_warnings.values(), [])
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF017
38 |         return chains + self._global_warnings
   |
   = help: Replace with `functools.reduce`

pymc/logprob/scan.py:398:54: RUF017 Avoid quadratic list summation
    |
396 |           # `Scan` (and get the corresponding indices of the outputs from this
397 |           # `Scan`)
398 |           output_clients: list[tuple[Variable, int]] = sum(
    |  ______________________________________________________^
399 | |             [
400 | |                 [
401 | |                     # This is expected to work for `Subtensor` `Op`s,
402 | |                     # because they only ever have one output
403 | |                     (cl.default_output(), i)
404 | |                     for cl, _ in fgraph.get_clients(out)
405 | |                     if isinstance(cl.op, Subtensor)
406 | |                 ]
407 | |                 for i, out in enumerate(node.outputs)
408 | |             ],
409 | |             [],
410 | |         )
    | |_________^ RUF017
411 |   
412 |           # The second items in these tuples are the value variables mapped to
    |
    = help: Replace with `functools.reduce`

pymc/variational/opvi.py:1618:16: RUF017 Avoid quadratic list summation
     |
1616 |     @property
1617 |     def params(self):
1618 |         return sum(self.collect("params"), [])
     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF017
     |
     = help: Replace with `functools.reduce`

Found 3 errors.
No fixes available (3 hidden fixes can be enabled with the `--unsafe-fixes` option).

ruff-format..........................................................................Passed
Disallow print statements............................................................Passed
Check no tests are ignored...........................................................Passed
Generate pip dependency from conda...................................................Passed
No relative imports..................................................................Passed
Check no links that should be cross-references are in the docs.......................Passed

Changed files

Changed 2 files:
  • .pre-commit-config.yaml
  • requirements-dev.txt

:octocat: Repo | 📝 Issues | 🏬 Marketplace


📚 Documentation preview 📚: https://pymc--7135.org.readthedocs.build/en/7135/

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94020c9) 90.17% compared to head (9ab8afa) 90.17%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7135   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         101      101           
  Lines       16932    16932           
=======================================
  Hits        15269    15269           
  Misses       1663     1663           

@ricardoV94 ricardoV94 deleted the create-pr-action/pre-commit-config-update-0 branch July 5, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant