Skip to content

Remove workflow to autoupdate pre-commit hook versions #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 23, 2024

Description

Autoupdate functionality is now handled by pre-commit-ci.

Closes #7135

Related Issue

See #7102 (comment)

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7112.org.readthedocs.build/en/7112/

@maresb
Copy link
Contributor Author

maresb commented Jan 23, 2024

Hmm, RTD is now failing? That's weird.

@maresb
Copy link
Contributor Author

maresb commented Feb 6, 2024

Closes #7135

Not sure why it's not linking

This functionality is replaced by pre-commit-ci.
@maresb maresb force-pushed the remove-pre-commit-autoupdate branch from faeccd6 to 31abeb5 Compare February 6, 2024 10:56
@ricardoV94
Copy link
Member

Closes #7135

Not sure why it's not linking

I don't think you can close PRs like that, only issues

@maresb maresb requested a review from ricardoV94 February 6, 2024 10:59
@ricardoV94 ricardoV94 merged commit c8a503c into pymc-devs:main Feb 6, 2024
@maresb maresb deleted the remove-pre-commit-autoupdate branch February 6, 2024 11:00
@ricardoV94
Copy link
Member

Ah the linking only works on the first message of the PR!

@maresb
Copy link
Contributor Author

maresb commented Feb 6, 2024

Ah the linking only works on the first message of the PR!

Actually I suspect you may be right about issues vs PRs. Note that I did edit the initial description with the closing keyword.

@ricardoV94
Copy link
Member

I think the other PR was automatically closed

@maresb
Copy link
Contributor Author

maresb commented Feb 6, 2024

I think the other PR was automatically closed

Ah, indeed! At least the timestamps agree to the minute.

Maybe it's just another GitHub glitch? Like it did get linked but didn't show up?

@ricardoV94 ricardoV94 added the no releasenotes Skipped in automatic release notes generation label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants