Skip to content

codespell to ignore URI's (second attempt) #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

drbenvincent
Copy link
Contributor

First attempt was #388
This is the second attempt

Fixes a frustration (see #385) where the pre-commit checks are editing the spelling within a URL to something which is wrong. It also has a complex set of effects on the ipynb vs myst files which can create differences and making it impossible to commit anything.

This PR updates .pre-commit-config.yaml to tell codespell to ignore spelling in URI's simply by appending "--uri-ignore-words-list", "*" to the arguments for `codespell``

Tagging @hectormz

drbenvincent and others added 30 commits January 24, 2021 16:43
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbenvincent
Copy link
Contributor Author

ARGH. Has changes to binning notebook despite me making no changes and not staging these files.

I tried to update my main before creating the feature branch with

git remote add upstream https://github.com/pymc-devs/pymc-examples.git
git fetch upstream
git checkout main
git merge upstream/main

And that normally does the job. Not 100% sure why this is happening

@drbenvincent drbenvincent deleted the codespell-ignore-URI branch July 4, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant