Skip to content

Update .pre-commit-config.yaml to tell codespell to ignore spelling in URI's #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

drbenvincent
Copy link
Contributor

Fixes a frustration (see #385) where the pre-commit checks are editing the spelling within a URL to something which is wrong. It also has a complex set of effects on the ipynb vs myst files which can create differences and making it impossible to commit anything.

This PR updates .pre-commit-config.yaml to tell codespell to ignore spelling in URI's simply by appending "--uri-ignore-words-list", "*" to the arguments for `codespell``

drbenvincent and others added 30 commits January 24, 2021 16:43
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbenvincent drbenvincent linked an issue Jul 2, 2022 that may be closed by this pull request
@drbenvincent drbenvincent requested a review from twiecki July 2, 2022 19:24
@hectormz
Copy link
Contributor

hectormz commented Jul 4, 2022

@drbenvincent does removing the binning notebooks relate to the changes to pre-commit hooks or did you want to remove those anyway?

@drbenvincent
Copy link
Contributor Author

drbenvincent commented Jul 4, 2022

Hi. I have no idea why there were changes to the binning notebook. But I've already deleted those from the PR.

EDIT: just to be clear, I was aiming to remove the unintentional changes to the binning notebook from the PR. Not intending the delete the binning notebook from the repo.

@hectormz
Copy link
Contributor

hectormz commented Jul 4, 2022

Ah got it. You may have fixed it locally, but they are still deleted in the current version of your PR branch: https://github.com/pymc-devs/pymc-examples/pull/388/files

If I were you, I think I'd just delete your local branch, remake the branch off of an up-to-date main, make your single commit and force push to GitHub now that you know:

args: ["--write-changes", "--ignore-words-list", "hist,fpr,fro,lik", "--uri-ignore-words-list", "*"]

@drbenvincent
Copy link
Contributor Author

Thanks, I'm very far from being a Git master. But I did update my main before creating the branch, so I'm confused how it happened. But I will try to follow your suggestions. If it messes up then I'll just destroy this and submit a new PR.

@drbenvincent drbenvincent deleted the precommit-ignore-uri branch July 4, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit getting in the way
2 participants