-
-
Notifications
You must be signed in to change notification settings - Fork 272
Update .pre-commit-config.yaml
to tell codespell
to ignore spelling in URI's
#388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@drbenvincent does removing the |
Hi. I have no idea why there were changes to the binning notebook. But I've already deleted those from the PR. EDIT: just to be clear, I was aiming to remove the unintentional changes to the binning notebook from the PR. Not intending the delete the binning notebook from the repo. |
Ah got it. You may have fixed it locally, but they are still deleted in the current version of your PR branch: https://github.com/pymc-devs/pymc-examples/pull/388/files If I were you, I think I'd just delete your local branch, remake the branch off of an up-to-date
|
Thanks, I'm very far from being a Git master. But I did update my main before creating the branch, so I'm confused how it happened. But I will try to follow your suggestions. If it messes up then I'll just destroy this and submit a new PR. |
Fixes a frustration (see #385) where the pre-commit checks are editing the spelling within a URL to something which is wrong. It also has a complex set of effects on the ipynb vs myst files which can create differences and making it impossible to commit anything.
This PR updates
.pre-commit-config.yaml
to tellcodespell
to ignore spelling in URI's simply by appending"--uri-ignore-words-list", "*"
to the arguments for `codespell``