Skip to content

add Stdlib::Port, Stdlib::Privilegedport & Stdlib::Unprivilegedport #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,88 @@ Unacceptable input example:
%.example.com

bob@example.com

#### `Stdlib::Port`

Matches a valid TCP/UDP Port number

Acceptable input examples:

```shell
80

443

1337

65000
```

Unacceptable input example:

-1

65536

'443'

'https'
````

#### `Stdlib::Port::Privileged

Matches a valid TCP/UDP Pivlaged port i.e. < 1024

Acceptable input examples:

```shell
80

443

1023
```

Unacceptable input example:

```shell
-1

1337

'443'

'https'
```

#### `Stdlib::Port::Unprivileged`

Matches a valid TCP/UDP Pivlaged port i.e. >= 1024

Acceptable input examples:

```shell
1024

1337

65000

```

Unacceptable input example:
```shell
-1

80

443

1023

'443'

'https'
```

### Facts
Expand Down
39 changes: 39 additions & 0 deletions spec/type_aliases/port__privileged_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
require 'spec_helper'

if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
describe 'Stdlib::Port::Privileged' do
describe 'valid ports' do
[
80,
443,
1023,
].each do |value|
describe value.inspect do
it { is_expected.to allow_value(value) }
end
end
end

describe 'invalid path handling' do
context 'garbage inputs' do
[
nil,
[nil],
[nil, nil],
{ 'foo' => 'bar' },
{},
'',
'https',
'443',
-1,
1337,
1024,
].each do |value|
describe value.inspect do
it { is_expected.not_to allow_value(value) }
end
end
end
end
end
end
40 changes: 40 additions & 0 deletions spec/type_aliases/port__unprivileged_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
require 'spec_helper'

if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
describe 'Stdlib::Port::Unprivileged' do
describe 'valid unprivilegedport' do
[
1024,
1337,
65_000,
].each do |value|
describe value.inspect do
it { is_expected.to allow_value(value) }
end
end
end

describe 'invalid path handling' do
context 'garbage inputs' do
[
nil,
[nil],
[nil, nil],
{ 'foo' => 'bar' },
{},
'',
'https',
'443',
-1,
80,
443,
1023,
].each do |value|
describe value.inspect do
it { is_expected.not_to allow_value(value) }
end
end
end
end
end
end
39 changes: 39 additions & 0 deletions spec/type_aliases/port_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
require 'spec_helper'

if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
describe 'Stdlib::Port' do
describe 'valid ports' do
[
80,
443,
1337,
65_000,
].each do |value|
describe value.inspect do
it { is_expected.to allow_value(value) }
end
end
end

describe 'invalid path handling' do
context 'garbage inputs' do
[
nil,
[nil],
[nil, nil],
{ 'foo' => 'bar' },
{},
'',
'https',
'443',
-1,
65_536,
].each do |value|
describe value.inspect do
it { is_expected.not_to allow_value(value) }
end
end
end
end
end
end
1 change: 1 addition & 0 deletions types/port.pp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
type Stdlib::Port = Integer[0, 65535]
1 change: 1 addition & 0 deletions types/port/privileged.pp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
type Stdlib::Port::Privileged = Integer[1, 1023]
1 change: 1 addition & 0 deletions types/port/unprivileged.pp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
type Stdlib::Port::Unprivileged = Integer[1024, 65535]