Skip to content

add Stdlib::Port, Stdlib::Privilegedport & Stdlib::Unprivilegedport #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

b4ldr
Copy link
Collaborator

@b4ldr b4ldr commented Nov 13, 2017

No description provided.

@b4ldr b4ldr mentioned this pull request Nov 13, 2017
@b4ldr
Copy link
Collaborator Author

b4ldr commented Nov 13, 2017

might be better to have

Stdlib::Port
Stdlib::Port::Privileged
Stdlib::Port::Unprivileged

happy to change if thats prfered

@b4ldr
Copy link
Collaborator Author

b4ldr commented Nov 30, 2017

rebased and updated to use new type testing as per #856

@b4ldr b4ldr force-pushed the type_ports branch 2 times, most recently from d403488 to 0c820a5 Compare November 30, 2017 16:40
@pegasd
Copy link
Contributor

pegasd commented Feb 8, 2018

I'd love to see some progress on this.
Is there a specific hold-up preventing something in here?

FWIW, I'd love to see the alternative naming version implemented. Namely, these would be great:

Stdlib::Port
Stdlib::Port::Privileged
Stdlib::Port::Unprivileged

@b4ldr
Copy link
Collaborator Author

b4ldr commented Feb 9, 2018

I did a rebase to fix the README conflict and renamed the types as suggested. Stdlib::Port::Privileged seems more inline with other types

@david22swan david22swan merged commit d5f3fe2 into puppetlabs:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants