(MODULES-3980) Fix ipv4 regex validator #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current pattern for stdlib::compat::ipv4 is incorrect, and will return true for any four numbers separated with periods. This commit improves the regex to validate that the IP octets are between 1 and 255.
ntpttr
force-pushed
the
fix/master/modules-3980
branch
from
9eff51e to
9bab173
Compare
|
Looks like jobs with ruby < 2.0 are failing because of a dependency with parallel_tests |
Parallel_tests 2.10.0 requires ruby >= 2.0.0, so for jobs with ruby < 2.0.0 parallel_tests 2.9.0 should be used.
ntpttr
force-pushed
the
fix/master/modules-3980
branch
from
9eae4bc to
8ef45bf
Compare
|
Also see #660 |
|
We are working on the parallel_tests fix via modulesync_config, so please don't edit the Gemfile directly (see https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/Gemfile#L1 ) |
|
Oh, I see you already did the modulesync :D |
Closed
DavidS
added a commit
to DavidS/puppetlabs-stdlib
that referenced
this pull request
Oct 24, 2016
This also updates all ipv4 tests to use the same test data for better comparability. Closes puppetlabs#676, puppetlabs#679 Fix-Originally-By: Nate Potter <nathaniel.potter@intel.com>
DavidS
added a commit
to DavidS/puppetlabs-stdlib
that referenced
this pull request
Oct 25, 2016
This also updates all ipv4 tests to use the same test data for better comparability. Closes puppetlabs#676, puppetlabs#679 Fix-Originally-By: Nate Potter <nathaniel.potter@intel.com>
DavidS
added a commit
to DavidS/puppetlabs-stdlib
that referenced
this pull request
Oct 25, 2016
This also updates all ipv4 tests to use the same test data for better comparability. Closes puppetlabs#676, puppetlabs#679 Fix-Originally-By: Nate Potter <nathaniel.potter@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pattern for stdlib::compat::ipv4 is incorrect, and
will return true for any four numbers separated with periods.
This commit improves the regex to validate that the IP octets
are between 1 and 255.