(MODULES-3980) Fix ipv4 regex validator

Nate Potter · Nate Potter · commit 9bab17305fbd · 2016-10-17T15:55:41.000-07:00
The current pattern for stdlib::compat::ipv4 is incorrect, and
will return true for any four numbers separated with periods.
This commit improves the regex to validate that the IP octets
are between 1 and 255.
diff --git a/spec/aliases/ipv4_spec.rb b/spec/aliases/ipv4_spec.rb
@@ -20,6 +20,8 @@
         'nope',
         '77',
         '4.4.4',
+        '9999.9999.9999.9999',
+        '192.168.256.1',
         '2001:0db8:85a3:0000:0000:8a2e:0370:73342001:0db8:85a3:0000:0000:8a2e:0370:7334'
       ].each do |value|
         describe value.inspect do
diff --git a/types/compat/ipv4.pp b/types/compat/ipv4.pp
@@ -1,2 +1,2 @@
 # Emulate the validate_ipv4_address and is_ipv4_address functions
-type Stdlib::Compat::Ipv4 = Pattern[/^(\d+)\.(\d+)\.(\d+)\.(\d+)$/]
+type Stdlib::Compat::Ipv4 = Pattern[/^(([0-9](?!\d)|[1-9][0-9](?!\d)|1[0-9]{2}(?!\d)|2[0-4][0-9](?!\d)|25[0-5](?!\d))[.]?){4}$/]

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`# Emulate the validate_ipv4_address and is_ipv4_address functions`
`2`		`-type Stdlib::Compat::Ipv4 = Pattern[/^(\d+)\.(\d+)\.(\d+)\.(\d+)$/]`
	`2`	`+type Stdlib::Compat::Ipv4 = Pattern[/^(([0-9](?!\d)\|[1-9][0-9](?!\d)\|1[0-9]{2}(?!\d)\|2[0-4][0-9](?!\d)\|25[0-5](?!\d))[.]?){4}$/]`